[SmartSwitch] Adding backward compatibility for feature "enable/disable vxlan sport filtering"#23207
Merged
prsunny merged 1 commit intosonic-net:masterfrom Apr 1, 2026
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
Pterosaur,
theasianpianist and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Config the port range and vxlan_security seperately, if the feature is not in the image, the range config can still be applied to the dut and the vxlan_security won't take effect. Signed-off-by: Cong Hou <[email protected]>
congh-nvidia
force-pushed
the
vxlan_src_port
branch
from
b271e84 to
4568e42
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StormLiangMS
approved these changes
Mar 24, 2026
Collaborator
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
LGTM — correct backward-compat split for VXLAN sport/security config. Skip condition for unavailable feature is well-justified. CI all green.
12 tasks
Collaborator
|
@congh-nvidia why are you adding the fix and skip the test case at the same time? |
Contributor
Author
Hi @yxieca , the fix is for the test case dash/test_dash_privatelink.py::test_privatelink_basic_transform and test_dash_smartswitch_vnet.py, the skip is for test case dash/test_dash_privatelink.py::test_privatelink_udp_sport_range_negative. Before the feature itself is merged, we should skip the negative test. I will remove the skip when the feature is present. |
theasianpianist
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The feature test PR #22908 is merged to master branch, however the feature itself has not been merged to sonic image.
The test_dash_privatelink.py and test_dash_smartswitch_vnet.py are broken due to this.
Adding a backward compatible method in both tests to make them work also without the feature, and skip the dedicated test case test_privatelink_udp_sport_range_negative before the feature is present.
Type of change
Back port request
Approach
What is the motivation for this PR?
Adding backward compatibility for feature "enable/disable vxlan sport filtering"
How did you do it?
How did you verify/test it?
Run the test_dash_privatelink.py and test_dash_smartswitch_vnet.py on SN4280 testbed with image that doesn't include the feature, all passed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation